Don't touch nor send messages to the root logger. #1380
+10
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently transformer_engine is writing to the root logger upon import, which implicitly initializes the root logger preventing downstream applications from controlling it effectively.
For further motivation on why the root logger should not be used by a library see https://docs.python.org/3/howto/logging.html#configuring-logging-for-a-library
This PR addresses this problem by ensuring all logging calls are done through dedicated transformer_engine loggers.
Fixes #1294
Type of change
Changes
Please list the changes introduced in this PR:
logging.info
duringtransfomer_engine
's (python) import which implicitly initializes the root logger preventing downstream applications from controlling it effectively.transformer_engine/pytorch/attention.py
, for similar reasons as the previous point.Checklist:
Prior to this change, despite the user setting the basicConfig after the import, it's ignore because transformer_engine already implicitly initialized it.
after the change